Feat/stripe #66
Merged
Feat/stripe #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgebaralt
commented
Sep 14, 2025
jorgebaralt
commented
- Add better Auth Stripe plugin
- Manage Stripe subscription from the new subscription modal
…hook, local listener)
rmolinamir
reviewed
Sep 16, 2025
Contributor
rmolinamir
left a comment
rmolinamir
left a comment
There was a problem hiding this comment.
This PR broke the build CI :
Error: Neither apiKey nor config.authenticator provided
See: stripe/stripe-js#667
Comment on lines
+13
to
+20
| const handleClick = () => { | ||
| setCancelUrl(pathname); | ||
|
|
||
| // Add a small delay to allow the dropdown to close before navigation | ||
| setTimeout(() => { | ||
| router.push("/auth/settings"); | ||
| }, 150); | ||
| }; |
Comment on lines
+60
to
+63
| quota: 250, // 2.5 USD | ||
| }, | ||
| name: "pro", | ||
| priceId: "price_1S2gQfK8Pm3Qm3VvhM5TuvWI", |
Contributor
There was a problem hiding this comment.
Needs to be configurable/parametized.
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "name": "@acme/stripe-listener", | |||
Contributor
There was a problem hiding this comment.
nit: Rename to stripe-tunnel or just stripe in case we add more local development goodies.
| "type": "module", | ||
| "scripts": { | ||
| "clean": "git clean -xdf .cache .turbo node_modules tsconfig.tsbuildinfo", | ||
| "dev": "stripe listen --forward-to localhost:3000/api/auth/stripe/webhook", |
Contributor
There was a problem hiding this comment.
Should be configurable (see localtunnel).
Comment on lines
+27
to
+49
| const handleClick = async (event: React.MouseEvent<HTMLButtonElement>) => { | ||
| setIsLoading(true); | ||
|
|
||
| if (!sessionData?.user?.id) { | ||
| toast.error("Please sign in to manage your subscription"); | ||
| return; | ||
| } | ||
|
|
||
| const result = await authClient.subscription.billingPortal({ | ||
| locale: "en", | ||
| referenceId: sessionData.user.id, | ||
| returnUrl: pathname, | ||
| }); | ||
|
|
||
| if (result.error) { | ||
| console.error("Billing portal error:", result.error); | ||
| toast.error("Failed to open billing portal. Please try again."); | ||
| } | ||
|
|
||
| // Call the custom onClick handler if provided | ||
| onClick?.(event); | ||
| setIsLoading(false); | ||
| }; |
Contributor
There was a problem hiding this comment.
Use react-query instead?
rmolinamir
reviewed
Sep 16, 2025
Comment on lines
+29
to
+39
| {isOnSubscriptionPage ? ( | ||
| <div className="flex items-center gap-2"> | ||
| <CreditCard /> | ||
| Subscription | ||
| </div> | ||
| ) : ( | ||
| <Link href="/subscription" className="flex items-center gap-2"> | ||
| <CreditCard /> | ||
| Subscription | ||
| </Link> | ||
| )} |
Contributor
There was a problem hiding this comment.
nit: Do we need to do this?
Comment on lines
+7
to
+14
| <DropdownMenuItem asChild className="w-full cursor-pointer"> | ||
| <form action={signOutAction} className="w-full"> | ||
| <button type="submit" className="flex w-full items-center gap-2"> | ||
| <LogOut /> | ||
| Sign out | ||
| </button> | ||
| </form> | ||
| </DropdownMenuItem> |
Comment on lines
+17
to
+20
| // Use effect to prevent hydration mismatch and flashing | ||
| useEffect(() => { | ||
| setIsOpen(pathname === "/subscription"); | ||
| }, [pathname]); |
Contributor
There was a problem hiding this comment.
TODO: I'll check this later
| error?: Error; | ||
| } | ||
|
|
||
| export class BillingErrorBoundary extends Component<Props, State> { |
| collapsible="offcanvas" | ||
| variant="floating" | ||
| className="sticky top-0 h-svh" | ||
| className="sticky top-0 z-10 h-svh" |
Comment on lines
+7
to
+9
| "module": "ES2022", | ||
| "moduleResolution": "bundler", | ||
| "skipLibCheck": true |
Contributor
There was a problem hiding this comment.
Is this needed? Not ESM friendly I think (which is not ideal).
Comment on lines
+12
to
+23
| id: text("id").primaryKey(), | ||
| plan: text("plan").notNull(), | ||
| referenceId: text("reference_id").notNull(), | ||
| stripeCustomerId: text("stripe_customer_id"), | ||
| stripeSubscriptionId: text("stripe_subscription_id"), | ||
| status: text("status").default("incomplete"), | ||
| periodStart: timestamp("period_start"), | ||
| periodEnd: timestamp("period_end"), | ||
| trialStart: timestamp("trial_start"), | ||
| trialEnd: timestamp("trial_end"), | ||
| cancelAtPeriodEnd: boolean("cancel_at_period_end"), | ||
| seats: integer("seats"), |
Contributor
There was a problem hiding this comment.
nit: I like keeping the underscores to avoid accidental bugs (skill issue lol).
| } from "drizzle-orm/pg-core"; | ||
|
|
||
| // Create the subscription table | ||
| export const subscription = pgTable("subscription", { |
Contributor
There was a problem hiding this comment.
Missing user_id foreign key.
| updatedAt: timestamp("updated_at") | ||
| .$defaultFn(() => /* @__PURE__ */ new Date()) | ||
| .notNull(), | ||
| stripeCustomerId: text("stripe_customer_id"), |
Contributor
There was a problem hiding this comment.
Remove this, rely on foreign key on the subscription table instead.
| id: text("id").primaryKey(), | ||
| plan: text("plan").notNull(), | ||
| referenceId: text("reference_id").notNull(), | ||
| stripeCustomerId: text("stripe_customer_id"), |
Contributor
There was a problem hiding this comment.
Probably needs to be unique.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.